From 64a1fb463eb81ac1600f9644bce2401bb7df2d1d Mon Sep 17 00:00:00 2001 From: lizerk Date: Wed, 18 Mar 2026 17:26:03 +0300 Subject: [PATCH] =?UTF-8?q?refactor(departments):=20=D1=83=D0=B4=D0=B0?= =?UTF-8?q?=D0=BB=D0=B8=D1=82=D1=8C=20=D0=B4=D1=83=D0=B1=D0=BB=D0=B8=D1=80?= =?UTF-8?q?=D1=83=D1=8E=D1=89=D0=B8=D0=B5=20create/destroy=20=D0=BC=D0=B5?= =?UTF-8?q?=D1=82=D0=BE=D0=B4=D1=8B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Методы дублировали стандартную функциональность ModelViewSet: - create(): serializer.save() делает то же самое - destroy(): стандартный метод идентичен -25 строк (510 → 485) --- backend/api/v1/employees/views/departments.py | 25 ------------------- 1 file changed, 25 deletions(-) diff --git a/backend/api/v1/employees/views/departments.py b/backend/api/v1/employees/views/departments.py index 3f1ab0a5..852b8f1f 100644 --- a/backend/api/v1/employees/views/departments.py +++ b/backend/api/v1/employees/views/departments.py @@ -483,28 +483,3 @@ class DepartmentViewSet(viewsets.ModelViewSet): user_qs = user_qs.order_by("name", "id") data = DepartmentBriefSerializer(user_qs, many=True).data return Response(data) - - def create(self, request, *args, **kwargs): - """Создание отдела.""" - ser = self.get_serializer(data=request.data) - ser.is_valid(raise_exception=True) - head = None - head_id = ser.validated_data.get("head") or ser.validated_data.get("head_id") - if head_id: - employee_model = Department._meta.get_field("head").remote_field.model - head = get_object_or_404(employee_model, id=head_id) - - dept = Department.objects.create( - name=ser.validated_data["name"], - description=ser.validated_data.get("description", ""), - head=head, - ) - return Response( - self.get_serializer(dept).data, status=status.HTTP_201_CREATED - ) - - def destroy(self, request, *args, **kwargs): - """Удаляет отдел.""" - dept = self.get_object() - dept.delete() - return Response(status=204)