Robotail/Corp - Corp - Robotail Git

Robotail/Corp

Fork 0

Commit Graph

Author	SHA1	Message	Date
igor_nadein	59b8f56c5a	refactor(employees): simplify create() using ExternalSystemSyncMixin Replaced 150+ lines of manual transaction management with mixin: Before: - Manual transaction.atomic() - Manual LDAP sync calls - Duplicate code for LDAP/non-LDAP modes - Manual error handling and rollback - ~150 lines of boilerplate After: - create() delegates to super() - миксин управляет всем - perform_create() - только БД логика (30 lines) - handle_external_sync_result() - обработка LDAP результата - Миксин автоматически управляет транзакциями и откатами Changes: 1. create(): simplified to validation + super().create() 2. perform_create(): creates Employee in DB, sets password/avatar/skills 3. prepare_external_data(): builds DTO with avatar_bytes, group_cns 4. handle_external_sync_result(): saves DN/GUID to LdapSyncState, sets employeeNumber, assigns position 5. ExternalSystemSyncMixin: added handle_external_sync_result() hook for custom post-sync actions Code reduction: 150 lines -> 80 lines Benefits: cleaner, DRYer, automatic error handling manage.py check: no issues	2026-02-16 17:07:15 +03:00
igor_nadein	df82e4f66d	feat: add ExternalSystemSyncMixin for universal LDAP/DB sync Created universal solution for ViewSet + external system synchronization: 1. ExternalSystemSyncMixin (common/external_sync_mixin.py): - Automatically wraps CRUD operations in transactions - Coordinates DB + LDAP in single atomic transaction - Rolls back DB if LDAP fails - Configurable error handling - Works with any external system (LDAP, APIs, etc) 2. Applied to EmployeeViewSet: - Added mixin to base classes - Configured LDAP sync mapping (create/update/destroy) - prepare_external_data() for DTO creation - handle_external_sync_error() for LDAP errors - No need to override create/update/destroy methods 3. Created pure LDAP methods in DirectoryService/UserService: - create_user_in_ldap_only() - LDAP create, returns dn/guid - update_user_in_ldap_only() - LDAP update, no DB access - delete_user_in_ldap_only() - LDAP delete, no DB access - All methods removed transaction.atomic (managed by ViewSet) 4. Documentation: - Complete guide in docs/guides/EXTERNAL_SYNC_MIXIN_GUIDE.md - Usage examples for all patterns - Migration guide from old architecture - Comparison with alternatives (Signals, Celery, Saga) Benefits: - Minimal code (3 methods vs overriding entire ViewSet) - Clear separation: View owns DB, LDAP service owns LDAP - Reusable for all ViewSets (departments, positions, etc) - Easy to test (external_sync_enabled = False) - Universal (works with any external system) manage.py check: System check identified no issues	2026-02-16 17:04:08 +03:00

Author

SHA1

Message

Date

igor_nadein

59b8f56c5a

refactor(employees): simplify create() using ExternalSystemSyncMixin

Replaced 150+ lines of manual transaction management with mixin:

Before:
- Manual transaction.atomic()
- Manual LDAP sync calls
- Duplicate code for LDAP/non-LDAP modes
- Manual error handling and rollback
- ~150 lines of boilerplate

After:
- create() delegates to super() - миксин управляет всем
- perform_create() - только БД логика (30 lines)
- handle_external_sync_result() - обработка LDAP результата
- Миксин автоматически управляет транзакциями и откатами

Changes:
1. create(): simplified to validation + super().create()
2. perform_create(): creates Employee in DB, sets password/avatar/skills
3. prepare_external_data(): builds DTO with avatar_bytes, group_cns
4. handle_external_sync_result(): saves DN/GUID to LdapSyncState,
   sets employeeNumber, assigns position

5. ExternalSystemSyncMixin: added handle_external_sync_result() hook
   for custom post-sync actions

Code reduction: 150 lines -> 80 lines
Benefits: cleaner, DRYer, automatic error handling

manage.py check: no issues

2026-02-16 17:07:15 +03:00

igor_nadein

df82e4f66d

feat: add ExternalSystemSyncMixin for universal LDAP/DB sync

Created universal solution for ViewSet + external system synchronization:

1. ExternalSystemSyncMixin (common/external_sync_mixin.py):
   - Automatically wraps CRUD operations in transactions
   - Coordinates DB + LDAP in single atomic transaction
   - Rolls back DB if LDAP fails
   - Configurable error handling
   - Works with any external system (LDAP, APIs, etc)

2. Applied to EmployeeViewSet:
   - Added mixin to base classes
   - Configured LDAP sync mapping (create/update/destroy)
   - prepare_external_data() for DTO creation
   - handle_external_sync_error() for LDAP errors
   - No need to override create/update/destroy methods

3. Created pure LDAP methods in DirectoryService/UserService:
   - create_user_in_ldap_only() - LDAP create, returns dn/guid
   - update_user_in_ldap_only() - LDAP update, no DB access
   - delete_user_in_ldap_only() - LDAP delete, no DB access
   - All methods removed transaction.atomic (managed by ViewSet)

4. Documentation:
   - Complete guide in docs/guides/EXTERNAL_SYNC_MIXIN_GUIDE.md
   - Usage examples for all patterns
   - Migration guide from old architecture
   - Comparison with alternatives (Signals, Celery, Saga)

Benefits:
- Minimal code (3 methods vs overriding entire ViewSet)
- Clear separation: View owns DB, LDAP service owns LDAP
- Reusable for all ViewSets (departments, positions, etc)
- Easy to test (external_sync_enabled = False)
- Universal (works with any external system)

manage.py check: System check identified no issues

2026-02-16 17:04:08 +03:00

2 Commits